Get rid of Fibers in honour of EventMachine since it’s already reached version 1 milestone#1
Open
mudasobwa wants to merge 13 commits intonegativecode:masterfrom
Open
Get rid of Fibers in honour of EventMachine since it’s already reached version 1 milestone#1mudasobwa wants to merge 13 commits intonegativecode:masterfrom
mudasobwa wants to merge 13 commits intonegativecode:masterfrom
Conversation
— last Fiber removed from Connection class in honour of EventMachine::Iterator ; — some cosmetic changes.
…ultiple instances of Vines’ services is done.
Author
|
Plus added asyncronous output from shell (for infinite looped commands like “ping google.com” or “tail -f …”). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— Introduced mutex on “register_handle” to prevent double-registering; the former solution with a variable “@ready” was not sufficient due to possible context switch inside “unless ready” block;
— Got rid of Fibers in honour of EventMachine, using mapped nested Iterators in the following manner:
— Introduced “@components” variable to collect components, if there are many returned by discovery. This is done ‘de bene esse’ and used currently to log warning of a kind “Hey, we use the first instance of components out of N available”